Remove robotV1 from code base (#20958) #20991
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am unsure which label should be applied since it's the removal of a deprecated API. I would guess |
wy65701436
reviewed
Oct 10, 2024
|
@sgaist please help to resolve the conflict, thanks. |
wy65701436
added
release-note/update
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20991 +/- ##
==========================================
+ Coverage 45.36% 46.12% +0.76%
==========================================
Files 244 247 +3
Lines 13333 13863 +530
Branches 2719 2867 +148
==========================================
+ Hits 6049 6395 +346
- Misses 6983 7132 +149
- Partials 301 336 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
It was deprecated in 2.4.0. Signed-off-by: Samuel Gaist <[email protected]>
sgaist
force-pushed
the
20958-remove-robotv1
branch
from
132a960 to
7189f36
Compare
Solved ! |
|
since, we're in the release cycle of v2.12. I will merge it after we branch v2.12, thanks. |
|
@wy65701436 Sure thing ! In between, would you be so kind and add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the deprecated robotV1 code and endpoint.
It was deprecated in 2.4.0.
Issue being fixed
Fixes #20958
Please indicate you've done the following: